WriteController: move it to public interface #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrambacher
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Technically, there is nothing to object to for this PR, so I guess it has to be approved.
However, every method here is not intended for public consumption and has no relevance to the user. The methods talk about do not call without the DB mutex, which the user does not have access to.
Since there is no technical reason to block this change, I am approving it. However, I still believe this feature has not been properly designed or documented.
Yuval-Ariel
force-pushed
the
574-global-delay-expose-writecontroller-to-public-api
branch
from
1d5bf39 to
f5721b1
Compare
Yuval-Ariel
force-pushed
the
574-global-delay-expose-writecontroller-to-public-api
branch
from
a500f9b to
5979248
Compare
Yuval-Ariel
deleted the
574-global-delay-expose-writecontroller-to-public-api
branch
udi-speedb
pushed a commit
that referenced
this pull request
Nov 22, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.